Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modal button ids #1755

Merged
merged 4 commits into from
May 30, 2022
Merged

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented May 9, 2022

Fix #1722

The functionality / appearance does not seem to be affected

Jonas Dittrich added 2 commits May 9, 2022 21:06
# Conflicts:
#	evap/contributor/templates/contributor_evaluation_form.html
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another

... in evap/contributor/templates/contributor_evaluation_form.html:67

Other than that, I checked the rendered code for the id from the feedback modal in the footer and it seems like it is unused

Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ UI functionality checked

@niklasmohrin niklasmohrin merged commit d3d3bf7 into e-valuation:main May 30, 2022
Kakadus added a commit to Kakadus/EvaP that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Modals specify ids for their buttons that are never used
4 participants