Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show display name for hidden questionnaires in result export #1751

Conversation

dieknolle3333
Copy link
Collaborator

closes #1487.
(For more info, read the issue 😅)

@dieknolle3333 dieknolle3333 force-pushed the show_display_name_for_hidden_questionnaires branch from e503566 to 86f4dcf Compare May 2, 2022 19:50
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it turns out that we don't need the name in exports and can always use the public_name here.

evap/results/tests/test_exporters.py Outdated Show resolved Hide resolved
evap/results/tests/test_exporters.py Outdated Show resolved Hide resolved
@dieknolle3333 dieknolle3333 force-pushed the show_display_name_for_hidden_questionnaires branch 4 times, most recently from f654d64 to 14c425b Compare May 16, 2022 20:48
show display name for all questionnaires in result export

add tests

fix formatting

address review

remove unnecessary test
@dieknolle3333 dieknolle3333 force-pushed the show_display_name_for_hidden_questionnaires branch from a3d3d9a to d45447e Compare May 23, 2022 18:38
@richardebeling richardebeling merged commit cfd0799 into e-valuation:main May 23, 2022
Kakadus pushed a commit to Kakadus/EvaP that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Questionnaire names in result exports
4 participants