Introduce MyPy #1688
Merged
Introduce MyPy #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
force-pushed
the
checkthisout
branch
from
79ad536
to
285ee36
Compare
niklasmohrin
force-pushed
the
checkthisout
branch
7 times, most recently
from
d909803
to
83c9fce
Compare
richardebeling
approved these changes
Jan 10, 2022
niklasmohrin
force-pushed
the
checkthisout
branch
from
83c9fce
to
c10893d
Compare
niklasmohrin
added a commit
to niklasmohrin/EvaP
that referenced
this pull request
Jan 18, 2022
We forgot to do so in e-valuation#1688
niklasmohrin
added a commit
that referenced
this pull request
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1653
As you can see, there are some places that need a
type: ignore, but overall I was surprised how little I had to change to make mypy pass. It seems to handle the untyped code fairly well.How do you all feel about static type checking?