Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add container prefix, add createnetwork to traefik #75

Merged
merged 7 commits into from
Aug 13, 2022
Merged

feat: add container prefix, add createnetwork to traefik #75

merged 7 commits into from
Aug 13, 2022

Conversation

polaroi8d
Copy link
Collaborator

@polaroi8d polaroi8d commented Aug 10, 2022 •
edited
Loading

PR contains the following issues:

  • Add the container prefix as a label to the container (dagent)
  • Add WithForcePullImage() to trafeik container (dagent)
  • Implement CreateNetwork in traefik mode (dagent)
  • Change TODO authors to GitHub profile nicknames
  • Fix the ContainerConfigExpose validation (crux, crux-ui)
  • Fix Resource Requests Memory default value

@polaroi8d polaroi8d requested a review from a team August 11, 2022 08:49
@polaroi8d polaroi8d marked this pull request as ready for review August 11, 2022 08:49
nandor-magyar
nandor-magyar reviewed Aug 11, 2022
View reviewed changes
agent/internal/grpc/grpc.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/container.go Show resolved Hide resolved
agent/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
robot9706
robot9706 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

robot9706
robot9706 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦎

ghost
ghost approved these changes Aug 12, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈‍⬛

@polaroi8d polaroi8d merged commit f62a939 into develop Aug 13, 2022
@polaroi8d polaroi8d deleted the feat/add-prefix-label-dagent branch August 13, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@robot9706 robot9706 robot9706 approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polaroi8d @m8vago @robot9706 @nandor-magyar