Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(agent): moved crane/dagent errors to v1 #66

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

robot9706
Copy link
Contributor

Crane and Dagent had almost the same errors defined for the REST interface. Moved these to the v1 common package.

@robot9706 robot9706 requested a review from a team August 8, 2022 08:36
@codecov-commenter
Copy link

Codecov Report

Merging #66 (ec85f71) into develop (402b401) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop     #66   +/-   ##
=======================================
  Coverage     6.70%   6.70%           
=======================================
  Files           58      58           
  Lines         4117    4117           
=======================================
  Hits           276     276           
  Misses        3832    3832           
  Partials         9       9           
Impacted Files Coverage Δ
agent/pkg/api/v1/error.go 0.00% <ø> (ø)
agent/pkg/crane/controller/deploy.go 0.00% <0.00%> (ø)
agent/pkg/crane/controller/kubeapi.go 0.00% <ø> (ø)
agent/pkg/crane/controller/update.go 0.00% <0.00%> (ø)
agent/pkg/crane/docs/crane_docs.go 100.00% <ø> (ø)
agent/pkg/dagent/controller/container.go 0.00% <0.00%> (ø)
agent/pkg/dagent/controller/update.go 0.00% <0.00%> (ø)
agent/pkg/dagent/docs/dagent_docs.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 😸 🌵

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please pay attention to squash the commits.

@robot9706 robot9706 merged commit c5ca22d into develop Aug 8, 2022
@robot9706 robot9706 deleted the refactor/agent-model-errors branch August 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants