Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(agent): eliminated globals & lint fixes #48

Merged
merged 9 commits into from
Jul 28, 2022
Merged

refactor(agent): eliminated globals & lint fixes #48

merged 9 commits into from
Jul 28, 2022

Conversation

robot9706
Copy link
Contributor

@robot9706 robot9706 commented Jul 27, 2022 •
edited
Loading

eliminiated global config instances
fixed some lint errors
added "gochecknoglobals" to lint config
added gin middleware for controllers to access the appconfig
created a custom grpc context for worker functions to access the appconfig

@robot9706
refactor(agent): eliminated globals & lint fixes
aaaaa35 
eliminiated global config instances
fixed some lint errors
added "gochecknoglobals" to lint config
@robot9706
refactor: fixing linting errors
c97bbca
@robot9706
refactor: added lint skip to some wanted globals
d6abc4f
@robot9706 robot9706 marked this pull request as ready for review July 27, 2022 11:57
@robot9706 robot9706 requested a review from a team July 27, 2022 11:57
nandor-magyar
nandor-magyar reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments.

agent/internal/sigmalr/sigmalr.go Outdated Show resolved Hide resolved
agent/pkg/api/v1/deploy.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/config.go Outdated Show resolved Hide resolved
agent/pkg/crane/crane_test.go Outdated Show resolved Hide resolved
agent/pkg/crane/k8s/deploy_facade.go Outdated Show resolved Hide resolved
agent/pkg/crane/k8s/deployment.go Outdated Show resolved Hide resolved
agent/pkg/crane/k8s/ingress.go Outdated Show resolved Hide resolved
agent/pkg/crane/k8s/namespace.go Show resolved Hide resolved
agent/pkg/crane/k8s/pvc.go Outdated Show resolved Hide resolved
agent/pkg/crane/k8s/service.go Outdated Show resolved Hide resolved
polaroi8d
polaroi8d requested changes Jul 27, 2022
View reviewed changes
agent/internal/grpc/grpc.go Outdated Show resolved Hide resolved
agent/pkg/api/v1/deploy.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/config.go Show resolved Hide resolved
agent/pkg/dagent/utils/container_builder.go Show resolved Hide resolved
agent/internal/version/version.go Outdated Show resolved Hide resolved
polaroi8d
polaroi8d approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM! 🔥

@robot9706 robot9706 mentioned this pull request Jul 28, 2022
Merged
nandor-magyar
nandor-magyar approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, approved!

@robot9706 robot9706 merged commit 98dd40e into develop Jul 28, 2022
@robot9706 robot9706 deleted the refactor/globals-lint branch July 28, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robot9706 @polaroi8d @nandor-magyar