Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crux-ui): name creation #429

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(crux-ui): name creation #429

merged 1 commit into from
Jan 17, 2023

Conversation

polaroi8d
Copy link
Collaborator

Pull request fixes the name creation error if the user adds whitespace to their name.

@polaroi8d polaroi8d added issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web. pr:fix lang:typescript severity:medium labels Jan 16, 2023
@polaroi8d polaroi8d requested a review from a team as a code owner January 16, 2023 15:47
@polaroi8d polaroi8d self-assigned this Jan 16, 2023
robot9706
robot9706 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📚

@polaroi8d polaroi8d merged commit 2acdf0e into develop Jan 17, 2023
@polaroi8d polaroi8d deleted the fix/profile-name branch January 17, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

Assignees

@polaroi8d polaroi8d

Labels
issue:improvement Issue that makes something better. lang:typescript pr:fix severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polaroi8d @robot9706