Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(web): update web deps #393

Merged
merged 7 commits into from
Dec 13, 2022
Merged

build(web): update web deps #393

merged 7 commits into from
Dec 13, 2022

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Dec 7, 2022

No description provided.

@m8vago m8vago requested a review from a team as a code owner December 7, 2022 16:17
ghost
ghost suggested changes Dec 7, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "chore(web)" would be a more fitting name.

Were the node updates intentional, as you use more recent but not LTS nodeJS versions in the Dockerfiles? Otherwise looks good.

@ghost ghost added source:web The scope of the issue or pull request is web. pr:chore labels Dec 7, 2022
@m8vago
Copy link
Contributor Author

m8vago commented Dec 7, 2022

I think "chore(web)" would be a more fitting name.

Were the node updates intentional, as you use more recent but not LTS nodeJS versions in the Dockerfiles? Otherwise looks good.

we checked this in conventional commits and it explicitly says build

@m8vago m8vago requested a review from a user December 7, 2022 17:28
@ghost
Copy link

ghost commented Dec 7, 2022

we checked this in conventional commits and it explicitly says build

Alright, then please add this word to .chglog/config.yml , so it can show up at the next release!

robot9706
robot9706 reviewed Dec 7, 2022
View reviewed changes
web/crux-ui/package.json Outdated Show resolved Hide resolved
robot9706
robot9706 reviewed Dec 7, 2022
View reviewed changes
web/crux/package.json Outdated Show resolved Hide resolved
robot9706
robot9706 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new lines at the end of package jsons, otherwise LGTM 😎

@m8vago m8vago force-pushed the build/web-dependencies branch 2 times, most recently from 8ff9ecf to 7991f56 Compare December 8, 2022 17:41
@m8vago m8vago force-pushed the build/web-dependencies branch 2 times, most recently from 2f503ed to 61ac3e9 Compare December 9, 2022 12:37
polaroi8d
polaroi8d reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to review? @m8vago

@m8vago m8vago changed the title build(web): update web deps [WIP] build(web): update web deps Dec 13, 2022
@m8vago
Copy link
Contributor Author

m8vago commented Dec 13, 2022

Ready to review? @m8vago

nope, still in progress, as the pipeline fails

@m8vago m8vago changed the title [WIP] build(web): update web deps build(web): update web deps Dec 13, 2022
@m8vago m8vago force-pushed the build/web-dependencies branch 2 times, most recently from fee720c to a98e379 Compare December 13, 2022 14:46
robot9706
robot9706 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@m8vago m8vago merged commit d584e87 into develop Dec 13, 2022
@m8vago m8vago deleted the build/web-dependencies branch December 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d left review comments

@robot9706 robot9706 robot9706 approved these changes

Assignees

@m8vago m8vago

Labels
pr:chore source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m8vago @robot9706 @polaroi8d