refactor(cli): silence container creation and rework logging #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
refactor/silence_and_rework_logging
branch
from
d6a008a
to
dfb0389
Compare
ghost
changed the title
ghost
added
issue:improvement
ghost
force-pushed
the
refactor/silence_and_rework_logging
branch
from
dfb0389
to
b878212
Compare
nandor-magyar
approved these changes
Nov 16, 2022
|
LGTM, but fix the failing pipeline. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes silence containercreation with cli, includes some loglevel change in crane and dagent, finally refactored few functions to use dockerhelper.