chore: dead code and linter updates #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nandor-magyar
commented
Nov 11, 2022
nandor-magyar
commented
- new golangci lint rules & fixes
- removed a bunch of dead code
- removed unused variables
nandor-magyar
force-pushed
the
chore/dead-code-and-linter
branch
2 times, most recently
from
30a9e10
to
206db53
Compare
Codecov ReportBase: 18.29% // Head: 18.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
+ Coverage 18.29% 18.50% +0.21%
===========================================
Files 53 52 -1
Lines 5077 5019 -58
===========================================
Hits 929 929
+ Misses 4125 4068 -57
+ Partials 23 22 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bvektor
approved these changes
Nov 11, 2022
nandor-magyar
force-pushed
the
chore/dead-code-and-linter
branch
from
6a82138
to
baf43eb
Compare
nandor-magyar
force-pushed
the
chore/dead-code-and-linter
branch
from
baf43eb
to
445f324
Compare
refactor(crux-ui): Separate contains methods from image config fix(crux): Add common error interceptor fix(crux-ui): Node status indicator position center feat(crux-ui): Add back btn to image details fix(crux-ui): Image list actions responsive display fix(crux-ui): Image config sections improvements fix(crux-ui): Deployment delete navigate fix(crux-ui): Confirmation modal cancel fix fix(agent): Inject secret key Co-Authored-By: Nandor Magyar <nandormagyar.it@gmail.com> fix(crux): Node create get identity notification error
nandor-magyar
force-pushed
the
chore/dead-code-and-linter
branch
from
445f324
to
83f10f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.