Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): invite flow revamp #332

Merged
merged 8 commits into from
Nov 16, 2022
Merged

feat(web): invite flow revamp #332

merged 8 commits into from
Nov 16, 2022

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Nov 11, 2022

feat: add first name and last name to the invite and register forms
feat: force invited users to set a password
feat: invited users' e-mail address will be automatically verified

@m8vago m8vago requested a review from a team as a code owner November 11, 2022 14:38
@m8vago m8vago force-pushed the feat/invite-flow-revamp branch 2 times, most recently from b6b34f4 to fc4a769 Compare November 11, 2022 17:20
robot9706
robot9706 requested changes Nov 14, 2022
View reviewed changes
web/crux-ui/locales/en/invitation.json Outdated Show resolved Hide resolved
web/crux-ui/locales/en/teams.json Outdated Show resolved Hide resolved
web/crux-ui/src/server/kratos.ts Outdated Show resolved Hide resolved
web/crux/src/app/team/pipes/team.reinvite-pipe.ts Outdated Show resolved Hide resolved
balanceee
balanceee suggested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@balanceee balanceee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some bugs while testing it.

  • The last logged in field shows never after declining the invite and creating a new team.
  • The profile page actions buttons are sliding apart

@m8vago
Copy link
Contributor Author

m8vago commented Nov 14, 2022

The last logged in field shows never after declining the invite and creating a new team.

That's intended. We should not expose if someone has a dyo account or when he/she logged in last time to dyo until that given user explicitly agree to join the team.

robot9706
robot9706 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

polaroi8d
polaroi8d requested changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add (web) scope to PR title, please.

@m8vago m8vago changed the title feat: invite flow revamp feat(web): invite flow revamp Nov 14, 2022
peterambrus3
peterambrus3 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@peterambrus3 peterambrus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_e2e failed, otherwise lgtm

@polaroi8d polaroi8d added issue:enhancement New feature or request source:web The scope of the issue or pull request is web. lang:typescript severity:high pr:test labels Nov 14, 2022
polaroi8d
polaroi8d approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits, otherwise LGTM.

@m8vago m8vago merged commit e044725 into develop Nov 16, 2022
@m8vago m8vago deleted the feat/invite-flow-revamp branch November 16, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robot9706 robot9706 robot9706 approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

@peterambrus3 peterambrus3 peterambrus3 approved these changes

@balanceee balanceee balanceee approved these changes

Assignees

@m8vago m8vago

Labels
issue:enhancement New feature or request lang:typescript pr:test severity:high source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m8vago @robot9706 @polaroi8d @peterambrus3 @balanceee