Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dagent): restart policy default + test #32

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

nandor-magyar
Copy link
Contributor

Some small version polish and default deployment value fixes with a basic unit test, though it won't protect people from misusing it, as it was done just before.

Note: branch was made from another, pending one, github should automatically handle this.

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the agent tests failing...

Base automatically changed from feat/agent-version to develop July 22, 2022 09:15
Done:
 - agent compile-time version (grpc, http)
 - display version on the node edit screen
@nandor-magyar nandor-magyar force-pushed the fix/restart-policy-default branch 5 times, most recently from 9f75c8b to 80a2073 Compare July 22, 2022 11:20
@nandor-magyar nandor-magyar merged commit 4bbfbec into develop Jul 22, 2022
@nandor-magyar nandor-magyar deleted the fix/restart-policy-default branch July 22, 2022 11:43
gitbook-com bot pushed a commit that referenced this pull request Aug 24, 2022
polaroi8d pushed a commit that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants