Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge go package into single module - go install #305

Merged
merged 1 commit into from
Oct 28, 2022
Merged

feat: merge go package into single module - go install #305

merged 1 commit into from
Oct 28, 2022

Conversation

nandor-magyar
Copy link
Contributor

This is started as a little experiment, but as I've tested it, this works without any modification to local envs or pipelines.

Notes:

  • binaries won't have different size
  • no changes to paths
  • no changes to Makefiles

This will probably let us go install cli (or crane or dagent).

@nandor-magyar nandor-magyar requested a review from a team as a code owner October 28, 2022 10:33
@nandor-magyar nandor-magyar self-assigned this Oct 28, 2022
polaroi8d
polaroi8d approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for me.

ghost
ghost approved these changes Oct 28, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks aight.

@nandor-magyar nandor-magyar merged commit 3d149b1 into develop Oct 28, 2022
@nandor-magyar nandor-magyar deleted the feat/golang-single-module branch October 28, 2022 15:58
balanceee pushed a commit that referenced this pull request Nov 2, 2022
@nandor-magyar @balanceee
feat: go package single module for simplicity (#305)
a1fa775
balanceee pushed a commit that referenced this pull request Nov 2, 2022
@nandor-magyar @balanceee
feat: go package single module for simplicity (#305)
3acbc45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels
issue:enhancement New feature or request lang:golang pr:feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandor-magyar @polaroi8d