Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): add some unit tests for dagent #263

Merged
merged 1 commit into from
Oct 20, 2022
Merged

refactor(test): add some unit tests for dagent #263

merged 1 commit into from
Oct 20, 2022

Conversation

Fall1ngStar
Copy link
Contributor

Add unit tests in dagent package to increase code coverage (#241)

@Fall1ngStar Fall1ngStar marked this pull request as ready for review October 13, 2022 21:04
@Fall1ngStar Fall1ngStar requested a review from a team as a code owner October 13, 2022 21:04
@Fall1ngStar
Copy link
Contributor Author

I've added unit tests to as much pure functions as I could, if you have any tips on how to add tests for functions that interact with other components, I'll be glad to add more tests

nandor-magyar
nandor-magyar requested changes Oct 14, 2022
View reviewed changes
agent/pkg/dagent/caps/parser_test.go Outdated Show resolved Hide resolved
agent/pkg/dagent/utils/import_container_test.go Outdated Show resolved Hide resolved
@polaroi8d polaroi8d requested a review from a team October 17, 2022 10:40
@polaroi8d polaroi8d added issue:improvement Issue that makes something better. pr:refactor lang:golang labels Oct 17, 2022
polaroi8d
polaroi8d approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal) thanks anyway good job. Could you please sign and rebase your commits?

@Fall1ngStar
Copy link
Contributor Author

Will do !

@polaroi8d polaroi8d linked an issue Oct 18, 2022 that may be closed by this pull request
Write unit tests for agent and we'll send you an awesome dyrectorio swag cap #241
Closed
@Fall1ngStar
test: add some unit tests for dagent
4cf144c 
test: improve naming
Signed-off-by: Fall1ngStar <fall1ngstar.public@gmail.com>
@Fall1ngStar Fall1ngStar changed the title test: add some unit tests for dagent refactor(test): add some unit tests for dagent Oct 19, 2022
nandor-magyar
nandor-magyar approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nandor-magyar nandor-magyar merged commit da536d4 into dyrector-io:develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees
No one assigned
Labels
issue:improvement Issue that makes something better. lang:golang pr:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write unit tests for agent and we'll send you an awesome dyrectorio swag cap
3 participants
@Fall1ngStar @polaroi8d @nandor-magyar