Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crux-ui): editor highlighting #260

Merged
merged 10 commits into from
Oct 14, 2022
Merged

feat(crux-ui): editor highlighting #260

merged 10 commits into from
Oct 14, 2022

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Oct 11, 2022

feat: add editor input highlighting to version image editing and deployment editing.
feat: add editors list to relevant pages
feat: add focus based saving
fix: a couple of websocket related errors
refactor: add useRepatch() and replace useReducer() in some components
refactor: state handling in websocket edited pages

@m8vago m8vago requested a review from a team as a code owner October 11, 2022 10:16
@m8vago m8vago marked this pull request as draft October 11, 2022 10:17
@m8vago m8vago force-pushed the feat/editor-highlighting branch 2 times, most recently from 3f954f6 to 93fa48a Compare October 11, 2022 11:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 10.24% // Head: 10.24% // No change to project coverage 👍

Coverage data is based on head (0c48b83) compared to base (66b16d8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #260   +/-   ##
========================================
  Coverage    10.24%   10.24%           
========================================
  Files           45       45           
  Lines         3857     3857           
========================================
  Hits           395      395           
  Misses        3449     3449           
  Partials        13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@m8vago m8vago marked this pull request as ready for review October 12, 2022 13:16
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo otherwise LGTM 😎

web/crux-ui/src/models/container.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@balanceee balanceee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@peterambrus3 peterambrus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment and lint error, otherwise lgtm

Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@m8vago m8vago merged commit 1dc41b1 into develop Oct 14, 2022
@m8vago m8vago deleted the feat/editor-highlighting branch October 14, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants