Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crux-ui): clear registry fields on type change #128

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

peterambrus3
Copy link
Contributor

fix(crux-ui): clear registry fields on type change

fix(crux-ui): google registry url not mapped in edit mode

@peterambrus3 peterambrus3 added issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web. labels Aug 31, 2022
@peterambrus3 peterambrus3 requested a review from a team August 31, 2022 13:07
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 but wait for @m8vago's comments

fix(crux-ui): clear registry fields on type change

fix(crux-ui): google registry url not mapped in edit mode

refactor(crux-ui): pr suggestions
Copy link
Contributor

@m8vago m8vago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@peterambrus3 peterambrus3 merged commit b8565ea into develop Sep 1, 2022
@peterambrus3 peterambrus3 deleted the fix/clear-registry-fields branch September 1, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants