-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(jest) Take seed coming from Jest whenever provided #3332
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 041f675:
|
Codecov Report
@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
- Coverage 95.50% 95.47% -0.04%
==========================================
Files 212 212
Lines 5829 5829
Branches 1075 1075
==========================================
- Hits 5567 5565 -2
- Misses 262 264 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Would it make sense to ask people to pass Might be breaking changes, but I'd be very interested to hear your thoughts (as it might mean changes to Jest would still be useful if there are blockers) 🙂 If the answer is "next major" that's understandable as well 👍 |
I added a small section recommending to add |
Cool 👍 Nothing missing in Jest (as of now, regarding this feature)? |
For now everything looks perfect |
🚀 |
I just launched a release for |
Version successfully released, see |
Jest 29.2 added an option to set a seed, which fast-check uses, and to show it. In the event of a failure, we can rerun the tests with the same seed, making debugging non-deterministic failures far simpler. I'm not sure why Dependabot isn't updating Jest/ts-jest to v29. Refs #388, a6b0f11, jestjs/jest#13400, dubzzz/fast-check#3332
Fixes #3287
Category:
Potential impacts: