Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 550 v6.0.0 beta6 #551

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Feature 550 v6.0.0 beta6 #551

merged 2 commits into from
Oct 18, 2024

Conversation

jprestop
Copy link
Contributor

@jprestop jprestop commented Oct 18, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Review the Release Notesin RTD

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Please review the Release Notes and ensure that all tests pass.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [20241018].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METviewer-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METviewer-6.0.0 milestone Oct 18, 2024
@jprestop jprestop requested a review from ishita9 October 18, 2024 17:11
@jprestop jprestop linked an issue Oct 18, 2024 that may be closed by this pull request
22 tasks
Copy link

@ishita9 ishita9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprestop jprestop merged commit d87d505 into develop Oct 18, 2024
6 checks passed
@jprestop jprestop deleted the feature_550_v6.0.0-beta6 branch October 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the METviewer-6.0.0-beta6 release
3 participants