Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 539 add test workflow #548

Merged
merged 16 commits into from
Sep 18, 2024
Merged

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Sep 17, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Verified that the Github Action was successful for the JUnit CI run

    • Very simple JUnit test for the MVUtil.java package with two assertTrue checks
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Verify that the Github Action is successful for the pull request
    
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [for now]

  • Will this PR result in changes to the test suite? [ No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe: Gatekeeper will identify duplicate code, etc.

  • Please complete this pull request review by [earliest convenience].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METviewer-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METviewer-6.0.0 milestone Sep 17, 2024
@bikegeek bikegeek linked an issue Sep 17, 2024 that may be closed by this pull request
24 tasks
Copy link

@ishita9 ishita9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify that the Github Action passed for this. I also reviewed the build.xml, test.yaml, and test files.

@bikegeek bikegeek merged commit 0030eca into develop Sep 18, 2024
5 checks passed
@bikegeek bikegeek deleted the feature_539_add_test_workflow branch September 18, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Add testing.yaml testing workflow
2 participants