Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 342 v3.0.0 beta6 #343

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Feature 342 v3.0.0 beta6 #343

merged 8 commits into from
Oct 17, 2024

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Reviewed the release notes at METdataio Version 3.0.0 Beta 6 Release Notes (20241017) and METdataio Upgrade Instructions.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the release notes METdataio Version 3.0.0 Beta 6 Release Notes (20241017) and METdataio Upgrade Instructions
Pay particular attention to the items that are bolded. I used my best judgement based on the priority tags listed on the issues, but would appreciate any feedback you have to give and requests for any changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [20241017].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METdataio-3.0.0 milestone Oct 16, 2024
@jprestop jprestop linked an issue Oct 16, 2024 that may be closed by this pull request
23 tasks
bikegeek
bikegeek previously approved these changes Oct 16, 2024
@jprestop
Copy link
Collaborator Author

Thanks for catching my mistake @bikegeek. I see that you added the ALTER TABLE section to the beta6 release section - thank you. I went in and removed it from the beta5 release section, but that voided your approval. Could you please reapprove?

@bikegeek
Copy link
Collaborator

bikegeek commented Oct 16, 2024 via email

@bikegeek bikegeek self-requested a review October 16, 2024 21:44
@jprestop jprestop merged commit 62e16e3 into develop Oct 17, 2024
2 of 9 checks passed
@jprestop jprestop deleted the feature_342_v3.0.0-beta6 branch October 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the METdataio-3.0.0-beta6 release
2 participants