-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 342 v3.0.0 beta6 #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
bikegeek
previously approved these changes
Oct 16, 2024
Thanks for catching my mistake @bikegeek. I see that you added the ALTER TABLE section to the beta6 release section - thank you. I went in and removed it from the beta5 release section, but that voided your approval. Could you please reapprove? |
Yes, I'll cancel the current workflows and then re-approve. The Github
workflows are still in the queue for METdataio. Everything is moving slowly
right now.
…On Wed, Oct 16, 2024 at 3:41 PM Julie Prestopnik ***@***.***> wrote:
Thanks for catching my mistake @bikegeek <https://github.com/bikegeek>. I
see that you added the ALTER TABLE section to the beta6 release section -
thank you. I went in and removed it from the beta5 release section, but
that voided your approval. Could you please reapprove?
—
Reply to this email directly, view it on GitHub
<#343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHT5SISBQJVHSIW2KRTZ33MP5AVCNFSM6AAAAABQCJCY6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGAYTKNRUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bikegeek
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Reviewed the release notes at METdataio Version 3.0.0 Beta 6 Release Notes (20241017) and METdataio Upgrade Instructions.
Review the release notes METdataio Version 3.0.0 Beta 6 Release Notes (20241017) and METdataio Upgrade Instructions
Pay particular attention to the items that are bolded. I used my best judgement based on the priority tags listed on the issues, but would appreciate any feedback you have to give and requests for any changes.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [N/A]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [20241017].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases