Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #318 tests for read data files #329

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

John-Sharples
Copy link

Changes

  • rejig how the test data is handled
  • add test for mtd 2d revision
  • add data and test for vsdb file

Pull Request Testing

  • Describe testing already performed for these changes:

    Test run locally

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Nil

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]
    Yes

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Yes, adds tests

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

* rework how test data dirs are handeled

* add test for read_data_files for mtd revisions
@georgemccabe georgemccabe merged commit f31a64e into develop Sep 11, 2024
15 checks passed
@georgemccabe georgemccabe deleted the feature_318-tests-for-read_data_files branch September 11, 2024 19:43
@georgemccabe georgemccabe changed the title Feature 318 tests for read data files Feature #318 tests for read data files Sep 11, 2024
@georgemccabe georgemccabe linked an issue Sep 11, 2024 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe added this to the METdataio-3.0.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create additional tests to METdataio to increase code coverage
2 participants