-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 320 update schema mpr orank #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. Test, config, and test data.
…olumns: names and additional columnsthat will break this test until the METreformat module is updated.
and the new columns are present.
26 tasks
mollybsmith-noaa
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a copy-paste error on lines 14 and 15 of METdbLoad/sql/updates/update_for_6_0_beta6.sql,
but otherwise everything looks good.
fixed the ADD COLUMN lines for ORANK
Good catch! I made the changes.
…On Wed, Aug 28, 2024 at 2:42 PM Molly Smith ***@***.***> wrote:
***@***.**** requested changes on this pull request.
You have a copy-paste error on lines 14 and 15 of
METdbLoad/sql/updates/update_for_6_0_beta6.sql, but otherwise everything
looks good.
—
Reply to this email directly, view it on GitHub
<#322 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHW7SJRS56A5XKWVORLZTYY2HAVCNFSM6AAAAABNHEMUXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRXGIZTANBYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mollybsmith-noaa
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
for MPR (line_data_mpr table):
and two columns are added:
for ORANK (line_data_orank table):
and two columns added:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [yes]
If yes, please describe:
duplicate code findings
Please complete this pull request review by Wednesday September 4.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases