Compatibility with numpy 1.24 #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Serov
suggested changes
Mar 8, 2023
According to the numpy documentation, |
|
Thanks! This is how I'm reading numpy's message. 😀 |
Alexander-Serov
approved these changes
Mar 8, 2023
|
@dswah Could you approve? |
|
Looks like the necessary changes were made to the main code and a new version released recently. I will close the PR. Thank you for getting the new version out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release of numpy 1.24.0, numpy deprecated and removed
np.int. This PR replacesnp.intwithnp.int_. The change was tested using numpy 1.23.5 and numpy 1.24.1 with Python 3.10.9.If you merge the PR, please release a new version of pyGAM on pypi.
Closes #326