Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline image support #4

Open
dsoskey opened this issue Mar 4, 2023 · 2 comments
Open

offline image support #4

dsoskey opened this issue Mar 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dsoskey
Copy link
Owner

dsoskey commented Mar 4, 2023

Is your feature request related to a problem? Please describe.
while CogLib's query runner runs offline, images are still loaded from scryfall. this means offline searches need a local image source. at the bare minimum, local should support full card text rendering.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Some quick math about storage requirements
medium quality image: ~93KB
number of unique prints: ~80k and rapidly growing
number of oracle cards: ~28k and growing slower than prints

estimated oracle size: 2.5 GiB
estimated print size: 7.2 GiB

@dsoskey dsoskey added the enhancement New feature or request label Mar 4, 2023
@RojjaCebolla
Copy link

RojjaCebolla commented Jun 17, 2024

i wonder if there could be like, a cache, where images expire based on number of times they've been accessed, and recency of that access?

so that if you have a burst of heavy use, you don't have to repeatedly load the cards you're interacting with, but if you drop or finish the project, those'll slowly phase out unless they're part of your regular activities/cubes

@dsoskey
Copy link
Owner Author

dsoskey commented Jun 17, 2024

LRU Caching is a good thought and could be tuned per device. Offline might be achieved through a desktop version of cogwork librarian, which opens the door for a much more robust backend redesign that would include this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants