Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DispatchNonShouldQueueToDispatchSyncRector for aliased jobs #230

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Fix DispatchNonShouldQueueToDispatchSyncRector for aliased jobs #230

merged 5 commits into from
Jul 17, 2024

Conversation

GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Jul 8, 2024

Fixes #224.

peterfox
peterfox approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@peterfox peterfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might be good to have a test that covers the scenario being fixed?

src/Rector/FuncCall/DispatchNonShouldQueueToDispatchSyncRector.php Outdated Show resolved Hide resolved
@GeniJaho @peterfox
Use static variable in DispatchNonShouldQueueToDispatchSyncRector
9d78802 
Co-authored-by: Peter Fox <peter.fox@peterfox.me>
@GeniJaho
Copy link
Collaborator Author

Looks good. Might be good to have a test that covers the scenario being fixed?

The test is in the PR being referenced. After merging this, the tests there should pass.

@GeniJaho GeniJaho merged commit be5c52a into driftingly:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfox peterfox peterfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeniJaho @peterfox