Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style #156

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Update code style #156

merged 7 commits into from
Jan 3, 2024

Conversation

driftingly
Copy link
Owner

@driftingly driftingly commented Dec 15, 2023

This PR updates the code style to use Duster.
Under the hood Duster relies on Laravel Pint for most of the rules.

Other updates:

  • Update rector ruleset to use 8.2
  • Update GitHub actions to bring everything 'in-house'
    • There were times where the reusable actions would update and break our pipeline
  • Update GitHub actions to remove automated commits - these have never worked well for me when used along side branch protection rules, often leading to a state where the action is waiting for some state.

@driftingly driftingly marked this pull request as ready for review December 15, 2023 23:23
@driftingly
Copy link
Owner Author

@GeniJaho You don't have to review this whole PR. Most of it is just updates to styles and some actions. Switch over to use Duster which is a tool I maintain for code style. It's similar to Easy Coding Standard but adds Pint and TLint.
Do you have any thoughts this move?

Copy link
Collaborator

@GeniJaho GeniJaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey that's fantastic, and PHP 8.3 as well 💪

@driftingly driftingly merged commit 7169143 into main Jan 3, 2024
5 checks passed
@driftingly driftingly deleted the drift/update-code-style branch January 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants