Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dwrite.dll loading process #6538

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented May 5, 2022

All supported OS always has dwrite.dll.

Microsoft Reviewers: Open in CodeFlow

All supported OS always has `dwrite.dll`.
@kant2002 kant2002 requested a review from a team as a code owner May 5, 2022 11:26
@ghost ghost assigned kant2002 May 5, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 5, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent May 5, 2022 11:26
@ghost ghost added the Community Contribution A label for all community Contributions label May 5, 2022
}
}

HMODULE hDWriteLibrary = LoadLibraryEx(L"dwrite.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
Copy link
Contributor

@lindexi lindexi May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 7, Windows Server 2008 R2, Windows Vista and Windows Server 2008: This value requires KB2533623 to be installed. See https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexa

Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! I miss that. But only Windows 7 SP1 is possible applicable since other OS does not supported by .NET 7
And even that seems to be KB2533623 required for .NET see dotnet/docs#20459

But I hardly can understand is ESU has this patch or not.

Copy link
Contributor

@Symbai Symbai May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vista and 2008 Server are not in the list of supported OS (at least for .NET 6) (research took too long, at time of answering kant2002 answer was not there)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be slated for .NET 8 then. That way Win 7 would be out of support at release date (Nov 2023) and not important anymore.

@dipeshmsft dipeshmsft self-assigned this Jan 19, 2023
@dipeshmsft
Copy link
Member

@kant2002 thanks for your contribution.

ThomasGoulet73 added a commit to ThomasGoulet73/wpf that referenced this pull request May 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants