Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Managed DWrite] Migrate Factory to managed #6171
[Managed DWrite] Migrate Factory to managed #6171
Changes from 11 commits
3ba4527
b59b454
3fb2018
693d46a
6944a79
7dd48dc
1a866dc
e1bc493
6523904
a1978ab
51bcafe
132849f
19bd765
49550d1
57c3799
8a874fa
c9226f3
34fe007
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now
GeneratedDllImport
is renamed toLibraryImport
and generally available to third party code. We should consider to use it like BCL.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this repo does not use
LibraryImport
yet, I don't want this large PR to be the first to use it. I think it would be best to do this in a smaller PR or in a PR the only migratesDllImport
toLibraryImport
.