[release/9.0] Removing invalid Fluent DataGridColumn styles #9896
+0
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dipeshmsft. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
dotnet-policy-service
bot
added
the
PR
singhashish-wpf
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # #9755
Main PR #9757
Description
Removes the invalid Fluent DataGridColumn styles, which can cause the application to crash when they are accessed explicitly.
Customer Impact
Developers trying to iterate through the Fluent theme ResourceDictionary will not face crash in their applications. Will allow easier migration to use the Fluent styles.
Regression
Not really, as this is part of the new Fluent styles being introduced in .NET 9. However, anyone who tries to use the new styles may face the following issues.
Testing
Local build, reproduction app and WPF Gallery application.
Risk
Minimal, no one is using the above styles currently ( except for .NET 9 preview and rc releases )
Microsoft Reviewers: Open in CodeFlow