Fixed feature test for XmlAttributeProperties.GetXmlNamespaceMaps and XmlAttributeProperties.SetXmlNamespaceMaps #264
Conversation
ghost
assigned 
ghost
requested review from
| try | ||
| { | ||
| XmlAttributeProperties.SetXmlNamespaceMaps(dobj, "foo"); | ||
| //Pass null to both dependencyObject and value in SetXmlNamespaceMaps, this will throw exception | ||
| XmlAttributeProperties.SetXmlNamespaceMaps(null, null); |
There was a problem hiding this comment.
Why we are testing whether SetXmlNamespaceMaps throws exception when setting null instead of testing if we can set the namespace maps with a correct value.
I am not aware if we have such a test case already. If not, I think we should add one.
There was a problem hiding this comment.
Here we are testing for null value just to see if it results in exception or not because SetXmlNamespaceMaps will throw exception in that scenario.
However for the correct value test we are checking that as well, please refer the code snippet from line 237 to 262.
| try | ||
| { | ||
| XmlAttributeProperties.GetXmlNamespaceMaps(dobj); | ||
| //Pass null to dependencyObject in GetXmlNamespaceMaps, this will throw exception | ||
| XmlAttributeProperties.GetXmlNamespaceMaps(null); |
There was a problem hiding this comment.
Here as well I think we should have a test case where we test whether we can get the correct value from the namespace maps or not.
There was a problem hiding this comment.
Please refer the code snippet from line 237 to 262.
Description
Fixed feature test for issue : XmlAttributeProperties.GetXmlNamespaceMaps throws System.InvalidCastException
Regression
None
Testing
Internal testing done, no new failures encountered.
Risk
None
Microsoft Reviewers: Open in CodeFlow