Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dotnet-sourcelink source-buildable #1028

Closed
oleksandr-didyk opened this issue May 16, 2023 · 2 comments · Fixed by #1068 or dotnet/installer#17002
Closed

Make dotnet-sourcelink source-buildable #1028

oleksandr-didyk opened this issue May 16, 2023 · 2 comments · Fixed by #1068 or dotnet/installer#17002

Comments

@oleksandr-didyk
Copy link
Contributor

Caused by https://github.com/dotnet/sourcelink/pull/933/files#r1185258895

dotnet-sourcelink should be part of source-build as per https://github.com/dotnet/sourcelink/pull/933/files#r1194071687.

Currently, allowing the project causes several OS-specific pre-builts to get pulled in:

    <Usage Id="Microsoft.AspNetCore.App.Runtime.osx-x64" Version="8.0.0-preview.3.23177.8" />
    <Usage Id="Microsoft.AspNetCore.App.Runtime.win-x64" Version="8.0.0-preview.3.23177.8" />
    <Usage Id="Microsoft.AspNetCore.App.Runtime.win-x86" Version="8.0.0-preview.3.23177.8" />
    <Usage Id="Microsoft.NETCore.App.Host.osx-x64" Version="8.0.0-preview.3.23174.8" />
    <Usage Id="Microsoft.NETCore.App.Host.win-x64" Version="8.0.0-preview.3.23174.8" />
    <Usage Id="Microsoft.NETCore.App.Host.win-x86" Version="8.0.0-preview.3.23174.8" />
    <Usage Id="Microsoft.NETCore.App.Runtime.osx-x64" Version="8.0.0-preview.3.23174.8" />
    <Usage Id="Microsoft.NETCore.App.Runtime.win-x64" Version="8.0.0-preview.3.23174.8" />
    <Usage Id="Microsoft.NETCore.App.Runtime.win-x86" Version="8.0.0-preview.3.23174.8" />

We should test if the property responsible for them (PackAsToolShimRuntimeIdentifiers) is even needed on Linux. If it is not - condition it out to resolve the pre-builts.

@NikolaMilosavljevic
Copy link
Member

This is required for dotnet/source-build#3052

@NikolaMilosavljevic
Copy link
Member

Working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants