Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF - sRGB Color Space Profile.icm is non-free #4590

Open
dviererbe opened this issue Sep 4, 2024 · 7 comments
Open

WPF - sRGB Color Space Profile.icm is non-free #4590

dviererbe opened this issue Sep 4, 2024 · 7 comments
Assignees
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@dviererbe
Copy link

dviererbe commented Sep 4, 2024

Describe the Bug

The .NET 9 source contains the file src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Resources/ColorProfiles/sRGB.icm. This file may not be distributed without fee if modified.

Steps to Reproduce

Go to the location https://github.com/dotnet/dotnet/blob/main/src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Resources/ColorProfiles/sRGB.icm in the VMR and see that it exists.

Other Information

  • There exists an old Debian Bug that describes the issue with this file: https://bugs.debian.org/657281
  • We just remove it from the Ubuntu source tarball as it is a windows only resource
@dotnet-issue-labeler dotnet-issue-labeler bot added area-upstream-fix Needs a change in a contributing repo untriaged labels Sep 4, 2024
@dviererbe dviererbe changed the title src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Resources/ColorProfiles/sRGB.icm sRGB Color Space Profile.icm is non-free WPF - sRGB Color Space Profile.icm is non-free Sep 4, 2024
@omajid
Copy link
Member

omajid commented Sep 4, 2024

The sRGB.icm file doesn't seem to have any licensing information (either embedded or via a sibling LICENSE file). How did you find the license this file is under?

@dviererbe
Copy link
Author

The sRGB.icm file doesn't seem to have any licensing information (either embedded or via a sibling LICENSE file). How did you find the license this file is under?

@omajid I used the tool lintian(1), which is a static analysis tool for deb packages. It showed the error message:

E: dotnet9 source: license-problem-md5sum-non-free-file usual name is sRGB.icm. This file may not be distributed without fee if modified. See also https://bugs.debian.org/657281. [src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Resources/ColorProfiles/sRGB.icm]

The tool found it based on the md5 hash sum.

@omajid
Copy link
Member

omajid commented Sep 4, 2024

The tool found it based on the md5 hash sum.

Oh, that's amazing!

@MichaelSimons
Copy link
Member

[Triage] @dotnet/dotnet-wpf - Can you provide details on how this file was obtained and what license it is under?

@MichaelSimons
Copy link
Member

[Triage] This is a blocker for distro maintainers in 9.0. It can be cloaked in 9.0 since the Unified Build project is not complete. It will need to be addressed in 10.0.

A secondary question is how can we detect this in our binary scan tool?

@dviererbe
Copy link
Author

A secondary question is how can we detect this in our binary scan tool?

I just commented on #4595 (comment) too:

You could just use the hash lists lintian uses to detect these files if you do not want to integrate the full lintian tool. They can be found here: https://salsa.debian.org/lintian/lintian/-/tree/master/data/cruft

E.g. here is the specific entry for the sRGB.icm file:
https://salsa.debian.org/lintian/lintian/-/blob/master/data/cruft/non-free-files#L39

@dipeshmsft
Copy link
Member

[Triage] @dotnet/dotnet-wpf - Can you provide details on how this file was obtained and what license it is under?

@MichaelSimons, this file was already part of the WPF source code when it was being open-sourced 5 years back. Apart from this, we don't have any information about the file yet.

I will try to find out more details about this from the previous WPF team members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
Status: 10.0
Development

No branches or pull requests

5 participants