-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip assertion list look ups where unnecessary #73142
Conversation
@dotnet/jit-contrib |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBelow is the list of metrics that I gathered before and after this change. They are based upon the instrumentation I added in #73035.
Benchmarks
Libraries
Asp
|
Ping. now that main is open for 8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think you should wait until we have a new SPMI collection and then rebase/re-trigger PR testing to ensure no diffs and that testing is recent.
a707dda
to
9b44443
Compare
No diffs as expected and the replay/diff failures are fixed in #74095 . |
Below is the list of metrics that I gathered before and after this change. They are based upon the instrumentation I added in #73035.
*CallCount
: Number of times we go through the look-up of that assertion category.*MissedCount
: Number of times we don't find any match of that assertion category.*MissedIter
: Number of iterations we spend before we realize there is no match.Benchmarks
Libraries
Asp