[RateLimiting] Add statistics API #72306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 Issue DetailsCloses #71804 I could be convinced that the chained rate limiter should use the largest queue count instead of the smallest. Also, the NoopLimiter could technically keep track of the successful leases and update the stats for that property.
|
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
src/libraries/System.Threading.RateLimiting/ref/System.Threading.RateLimiting.cs
Show resolved
Hide resolved
halter73
reviewed
Jul 20, 2022
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
...raries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/ConcurrencyLimiter.cs
Show resolved
Hide resolved
src/libraries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/NoopLimiter.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
force-pushed
the
brecon/stats
branch
from
37a2bc3
to
900a56c
Compare
BrennanConroy
force-pushed
the
brecon/stats
branch
from
900a56c
to
83d46c2
Compare
halter73
approved these changes
Aug 11, 2022
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Show resolved
Hide resolved
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
force-pushed
the
brecon/stats
branch
from
177c35c
to
955f12c
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71804
I could be convinced that the chained rate limiter should use the largest queue count instead of the smallest.
Also, the NoopLimiter could technically keep track of the successful leases and update the stats for that property.