Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compiler record to PDB files in Crossgen2 #59686

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

davidwrighton
Copy link
Member

This adds a new record to pdb's generated by crossgen2 so that the particular compiler version used to build the R2R file can be seen in the pdb

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just as beautiful as I expected. Thank you!

Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwrighton
Copy link
Member Author

@VCZYK could you take a look at this and validate that it makes sense. I'd add you as a reviewer, but the GitHub UI doesn't want to do that right now.

@davidwrighton davidwrighton merged commit fcde5f6 into dotnet:main Sep 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@davidwrighton davidwrighton deleted the addCompilerRecordToPdb branch April 13, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants