Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guarded Devirt: multiple type checks #59604
Guarded Devirt: multiple type checks #59604
Changes from 21 commits
c1c9626
f58f930
ad6daec
7d7bbac
c629fa1
c2cbe9d
7495913
781c2e7
07e20cc
bcf7b4f
81c94af
c048c64
6a3bdff
37ca01f
756dfdb
a76b01b
80c3399
b9a1a05
db50163
8e70304
158b7d4
e6c989a
616c97f
720be25
710c149
3805cb3
5f68a56
1043290
910c5c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make a call node bigger?
If we have room for this, do we have enough room to make the union above a tagged union?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndyAyersMS Not sure I follow, here is the current win-x64 layout (before my changes) in Release
/d1reportSingleClassLayoutGenTreeCall
:in theory we can fit the count into those spare 3 bits? (means maxvalue is 7) if the size matters that much - not sure about impact on other archs/os