Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of runtime test build scripts #58762

Merged
merged 11 commits into from
Oct 6, 2021
Merged

Commits on Sep 29, 2021

  1. Move native test build over to the src/tests/build.proj script

    Improve passing of parameters to MSBuild; fix native build on Windows
    
    Add detection of __RepoRootDir to eng/native/build-commons.sh
    
    Fix additional _build-commons.sh source needed for handle_arguments
    
    Attempt at fixing the secondary bash source for native build
    
    Native build passing on both Windows and Unix
    
    Combine NativeBuild and BatchRestorePackages into a new TestBuild target
    
    Add managed build to the overarching TestBuild target
    
    Unify handling of __Priority between Windows and Unix
    
    Fix naming variance of the SkipPackageRestore flag
    
    More fixes for package restoration
    
    Fix build target on Unix
    
    Test pipeline full moved to msbuild on Windows
    
    Simplify the target CreateTestOverlay
    
    Simplify CreateTestOverlay target
    
    Fix naming of the CORE_ROOT variable
    
    Fix missing parameters in build.sh (ProjectFilesDir, BinDir, TestBinDir)
    
    Fix build of 1st managed test group
    
    Fix passing CORE_ROOT in publishdependency.targets
    
    Improve condition for the BuildTestWrappers target
    
    Add support for MsgPrefix & ErrMsgPrefix; centralize build step conditions
    
    Revert part of the change pertaining to native test component build per Jeremy's PR feedback; fix processor count on Unix
    
    Fix logic around SkipTestWrappers in build.sh (put it in sync with build.cmd)
    
    Clean up logic around package restoration
    
    Exporting [Err]MsgPrefix as environment vars due to issues with escaping; may need to do the same for all the properties
    
    Fix skipping native build in BuildTestWrappersOnly mode
    
    Skip native build in GenerateLayoutOnly mode
    
    Fix CopyNativeTestBinaries step
    
    Fix support for __Exclude (issues.targets); simplify property passing
    
    Remove the irregularity between CopyNativeProjectBinaries vs. __CopyNativeProjectsAfterCombinedTestBuild
    
    Fix passing of RuntimeFlavor
    
    Fix copynativeonly mode
    
    Put build step conditions back to the individual targets
    
    Typo
    
    Fix dependency graph w.r.t. RestorePackages
    
    Don't suppress package restore as part of the native artifact copying step
    
    Fix native test component build broken due to subtle property changes
    
    Fix logic around copynativeonly
    
    Run restore when copying over native components
    
    Clean up copying native test components
    
    Fix bug in construction of CORE_ROOT in RunTests
    
    Fix incorrect merge
    
    Fix issues.targets on Unix; add instrumentation to test wrapper build
    
    More instrumentation
    
    More instrumentation
    
    Typo
    
    One more typo
    
    Fix copying of native test references
    
    Skip managed test build in 'buildtestwrappersonly' mode
    
    Fix support for __GenerateLayoutOnly
    
    Remove temporary instrumentation; fix handling of RunWithAndroid flag
    
    Don't run the 'standard' native & managed test build in MonoAot mode
    
    Fix MonoBinDir
    
    Remove incorrect setting of _CMDDIR; put back instrumentation to understand issues with test wrappers on Linux
    
    Fix manipulation of XunitTestBinBase on Linux
    
    Put copynativeonly mode in sync between Windows and Unix
    
    Remove instrumentation after confirming that test wrappers now build fine on Unix
    
    Fix issues.targets exclusions on Unix per Nathan's PR feedback
    
    Add binlog production to msbuild invocation on Unix
    
    Clean up some obsoleted variables in build.sh
    
    Put back incorrectly removed __CommonMSBuildArgs; remove __BuildProperties
    
    Fix typo in issues.targets
    
    Fix missing path separator in issues.targets
    
    Add trailing directory separator to XunitTestBinBase; normalize paths
    
    Typo
    
    Instrumentation to figure out why the runtime variant info gets dropped in some legs
    
    Fix logging
    
    More cleanup and instrumentation to nail down the RuntimeVariant bug
    
    Add support for step-specific log names in test build
    
    Typo
    
    Fix erroneous use of the new buildLogRootName arg in the base build.sh
    
    Fix layout generation to stop automatically generating test wrappers
    
    Typo
    
    Keep binlog for local instrumentations only, not as the default
    
    Fix framework crossgenning on Linux and perfmap support
    
    One more fix for framework crossgenning
    
    Fix test priority propagation
    
    Migrate common properties to Directory.Build.props
    
    Force out-of-proc msbuild execution for building managed test groups
    
    Fix library configuration in child msbuild execution
    trylek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    75bb058 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e7b798 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c7e2eed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    250aa13 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Configuration menu
    Copy the full SHA
    21700ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cbc2cd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4270c4e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Address part of Jeremy's PR feedback

    This change addresses the simpler aspects of Jeremy's feedback
    (organization, naming, documentation). I'll address the CallTarget
    comment in a follow-up commit. For the environment variables,
    I would indeed prefer to address that separately in a follow-up
    change as Jeremy himself suggested in his PR feedback.
    
    Thanks
    
    Tomas
    trylek committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    fd1e82c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e559efd View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Configuration menu
    Copy the full SHA
    1340a1f View commit details
    Browse the repository at this point in the history
  2. Revert "Remove obsolete warnAsError suppression per Jeremy's PR feedb…

    …ack"
    
    This reverts commit e559efd.
    trylek committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    553ccd6 View commit details
    Browse the repository at this point in the history