Enable cryptography tests hitting libssl issue #32255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Feb 13, 2020
src/coreclr/Directory.Build.props
Outdated
| @@ -5,6 +5,8 @@ | |||
| </PropertyGroup> | |||
| <Import Project="..\..\Directory.Build.props" /> | |||
|
|
|||
| <!-- foo --> | |||
There was a problem hiding this comment.
Guessing you didn't mean to add this 😄
There was a problem hiding this comment.
I did, to trigger coreclr and mono tests to increase the probability of hitting the issue. I added it as a separate commit though. Will remove it before merging of course.
jaredpar
reviewed
Feb 13, 2020
src/mono/mono.proj
Outdated
| @@ -2,6 +2,8 @@ | |||
| <Import Project="Directory.Build.props" /> | |||
| <Import Project="Directory.Build.targets" /> | |||
|
|
|||
| <!-- Foo --> | |||
There was a problem hiding this comment.
The OCD part of my brain is upset that you choose to capitalize Foo differently in different files.
jaredpar
approved these changes
Feb 13, 2020
ViktorHofer
approved these changes
Feb 13, 2020
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
safern
added
the
NO-MERGE
safern
force-pushed
the
EnableCryptoTests
branch
from
9d1f4cd
to
3bd5017
Compare
safern
removed
the
NO-MERGE
|
Ok, so I've ran the tests like 4 or 5 times already and I haven't hit the libssl issue, all the failures I've hit are the known issues related to execute.sh not having permissions. I will go ahead and merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2176
Let's re-enable them and try multiple runs to make sure the machines are not affected anymore.
cc: @ViktorHofer @jaredpar @bartonjs