Change RegexCompiler to special-case sets of just 2 or 3 chars #31734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we need to emit the code to match a character against a set, we call a helper that checks lots of conditions and determines the best code to output for that check, e.g. if the set is '\d', we just emit a call to
char.IsDigit
, or if the set contains a single range, we emit a simple range check. It turns out it's common to have sets with just two or three characters in them, in particular coming from our prefix checker that, e.g. for a global alternation, will generate a set containing the first possible characters of each branch. In master we generate a lookup table for such a set, but that involves computing the bit offset from the lookup table, doing the appropriate shifts, indexing, etc.; for two or three characters, it's cheaper to just perform the two or three comparison operations. For example, this makes a few percent improvement on regex redux, where we end up doing lots of these comparisons.cc: @danmosemsft, @eerhardt, @ViktorHofer