Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nullability annotation to string ctor #31702

Merged
merged 1 commit into from
Feb 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/String.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public sealed partial class String : IComparable, IEnumerable, IConvertible, IEn

[MethodImpl(MethodImplOptions.InternalCall)]
[PreserveDependency("Ctor(System.Char[])", "System.String")]
public extern String(char[] value);
public extern String(char[]? value);

#if !CORECLR
static
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime/ref/System.Runtime.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2304,7 +2304,7 @@ public unsafe String(char* value) { }
[System.CLSCompliantAttribute(false)]
public unsafe String(char* value, int startIndex, int length) { }
public String(char c, int count) { }
public String(char[] value) { }
public String(char[]? value) { }
public String(char[] value, int startIndex, int length) { }
public String(System.ReadOnlySpan<char> value) { }
[System.CLSCompliantAttribute(false)]
Expand Down