Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 32 byte alignment of code on xarch #2249

Merged
merged 4 commits into from
Feb 15, 2020
Merged

Support 32 byte alignment of code on xarch #2249

merged 4 commits into from
Feb 15, 2020

Commits on Feb 14, 2020

  1. Support 32 byte alignment of code on xarch 

    Update jit and runtime to allow jit to ask for code to be 32 byte aligned.
Request 32 byte alignment for Tier1 methods on x86/x64.

Add minimal crossgen support; one can imagine requesting or choosing 32 byte
alignment for crossgenned code, but that is left as future work.

This should provide some measure of performance stability, in particular for
microbenchmarks or other code where performance depends crucially on a few
branches.

It may or may not improve performance. If/when there are regressions we can
contemplate updating the jit to add intra-method padding to address alignment
sensitive code layout (e.g. dotnet/coreclr#11607).

This will require a jit GUID update in addition to the changes here.
    @AndyAyersMS
    AndyAyersMS committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    309e2ae View commit details
    Browse the repository at this point in the history

  2. restrict to larger methods with loops; don't update zapper

    @AndyAyersMS
    AndyAyersMS committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3cc708c View commit details
    Browse the repository at this point in the history

  3. new jit GUID

    @AndyAyersMS
    AndyAyersMS committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    452e104 View commit details
    Browse the repository at this point in the history

  4. fix target ifdef name

    @AndyAyersMS
    AndyAyersMS committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    daf588a View commit details
    Browse the repository at this point in the history