Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net.Dns.RunAsync() does not decrement telemetry for canceled requests #92045

Closed
sandersaares opened this issue Sep 14, 2023 · 2 comments · Fixed by #104435
Closed

System.Net.Dns.RunAsync() does not decrement telemetry for canceled requests #92045

sandersaares opened this issue Sep 14, 2023 · 2 comments · Fixed by #104435
Assignees
Labels
area-System.Net bug in-pr There is an active PR which will close this issue when it is merged tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Milestone

Comments

@sandersaares
Copy link

sandersaares commented Sep 14, 2023

If a call that ends up in Dns.RunAsync() is canceled, nothing ever calls NameResolutionTelemetry.AfterResolution() and so the variable NameResolutionTelemetry._currentLookups remains forever incremented by one.

The unmatched BeforeResolution() is called in Dns.RunAsync() here: https://github.com/dotnet/runtime/blob/9101b853a1f5194de3e7bc495454a57df0da300e/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs#L652C16-L652C16

image

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

If a call to Dns.GetHostAddressesAsync() (or similar) is canceled, nothing ever calls NameResolutionTelemetry.AfterResolution() and so the variable NameResolutionTelemetry._currentLookups remains forever incremented by one.

The unmatched BeforeResolution() is called in Dns.RunAsync() here: https://github.com/dotnet/runtime/blob/9101b853a1f5194de3e7bc495454a57df0da300e/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs#L652C16-L652C16

image

Author: sandersaares
Assignees: -
Labels:

area-System.Net

Milestone: -

@sandersaares sandersaares changed the title System.Net.NameResolution.Dns.RunAsync() does not decrement telemetry for canceled requests System.Net.Dns.RunAsync() does not decrement telemetry for canceled requests Sep 14, 2023
@karelz
Copy link
Member

karelz commented Sep 14, 2023

Triage: Worth having, but not critical, moving to 9.0.
We should consider including it in servicing of #81023 if we come to that.

@karelz karelz added this to the 9.0.0 milestone Sep 14, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 14, 2023
@karelz karelz added bug tenet-reliability Reliability/stability related issue (stress, load problems, etc.) labels Sep 14, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 1, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 4, 2024
@antonfirsov antonfirsov self-assigned this Jun 25, 2024
@rokonec rokonec assigned rokonec and unassigned antonfirsov Jul 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net bug in-pr There is an active PR which will close this issue when it is merged tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
None yet
4 participants