Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider creating a ranged version of CORINFO_HELP_ASSIGN_BYREF #8627

Closed
AndyAyersMS opened this issue Jul 24, 2017 · 0 comments · Fixed by #101761
Closed

Consider creating a ranged version of CORINFO_HELP_ASSIGN_BYREF #8627

AndyAyersMS opened this issue Jul 24, 2017 · 0 comments · Fixed by #101761
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Milestone
9.0.0

Comments

@AndyAyersMS
Copy link
Member

We often see numerous back to back calls to this helper that could be trivially turned into one call with a count. For instance:

;; System.TupleExtensions:CreateLong(ref,ref,ref,ref,ref,ref,ref,ref):struct
       mov      rdi, rbx
       lea      rsi, bword ptr [rbp-68H]
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF
       call     CORINFO_HELP_ASSIGN_BYREF

Each call does a series of range checks, a write, a card table update, and src/dest pointer updates, so there is a lot of overhead here that could be reduced via ranged version.

category:cq
theme:helpers
skill-level:expert
cost:medium
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@EgorBo EgorBo mentioned this issue Feb 29, 2024
Closed
4 tasks
@EgorBo EgorBo self-assigned this Feb 29, 2024
@EgorBo EgorBo modified the milestones: Future, 9.0.0 Feb 29, 2024
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Feb 29, 2024
@EgorBo EgorBo mentioned this issue May 2, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Bulk copy of byrefs EgorBo/runtime-1
Batched write barrier for byrefs EgorBo/runtime-1
4 participants
@EgorBo @msftgits @AndyAyersMS @BruceForstall