Builds failing with error: use of undeclared identifier 'swprintf_s'

[elinor-fung]

Likely from #77228

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=58398&view=logs&jobId=c15592f9-a6ec-52c9-e864-c0455e061f15&j=c15592f9-a6ec-52c9-e864-c0455e061f15&t=e6ee899e-01c1-5f09-519b-c43bc88cb55e

[ 84%] Building CXX object dlls/dbgshim/CMakeFiles/dbgshim.dir/dbgshim.cpp.o
  /Users/runner/work/1/s/src/mono/dlls/dbgshim/dbgshim.cpp:64:5: error: use of undeclared identifier 'swprintf_s'
      swprintf_s(w_android_run_adb_command, 2048, W("%ws %ws"), w_android_adb_path, w_command_to_execute);
      ^
  1 error generated.
  make[2]: *** [dlls/dbgshim/CMakeFiles/dbgshim.dir/dbgshim.cpp.o] Error 1
  make[1]: *** [dlls/dbgshim/CMakeFiles/dbgshim.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

@AaronRobinsonMSFT

[ghost]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Likely from #77228

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=58398&view=logs&jobId=c15592f9-a6ec-52c9-e864-c0455e061f15&j=c15592f9-a6ec-52c9-e864-c0455e061f15&t=e6ee899e-01c1-5f09-519b-c43bc88cb55e

[ 84%] Building CXX object dlls/dbgshim/CMakeFiles/dbgshim.dir/dbgshim.cpp.o
  /Users/runner/work/1/s/src/mono/dlls/dbgshim/dbgshim.cpp:64:5: error: use of undeclared identifier 'swprintf_s'
      swprintf_s(w_android_run_adb_command, 2048, W("%ws %ws"), w_android_adb_path, w_command_to_execute);
      ^
  1 error generated.
  make[2]: *** [dlls/dbgshim/CMakeFiles/dbgshim.dir/dbgshim.cpp.o] Error 1
  make[1]: *** [dlls/dbgshim/CMakeFiles/dbgshim.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

@AaronRobinsonMSFT

Author:	elinor-fung
Assignees:	-
Labels:	area-Diagnostics-coreclr
Milestone:	-

[AaronRobinsonMSFT]

FYI @janvorli and @jkotas We are again hitting the PAL being pulled into unexpected places.

[BruceForstall]

Maybe eng\pipelines\common\evaluate-default-paths.yml needs to be updated so the right tests get triggered for mono?

[am11]

unexpected places.

Mono debug shim is there since .NET 6 preview 4: 82e8d0e

[elinor-fung]

Maybe eng\pipelines\common\evaluate-default-paths.yml needs to be updated so the right tests get triggered for mono?

Yeah, I think we should update at least

runtime/eng/pipelines/common/evaluate-default-paths.yml

Line 61 in a46a28e

- subset: mono_excluding_wasm

to trigger on src/coreclr/pal changes.

[jkotas]

It should be on all src/coreclr changes. The Mono dbg shim depends on like number of different pieces from src/coreclr

[elinor-fung]

Ah, then I guess it is more we need to stop excluding src/coreclr

runtime/eng/pipelines/common/evaluate-default-paths.yml

Line 79 in a46a28e

- src/coreclr/*

[AaronRobinsonMSFT]

Fix is up - #77284

Please someone tell me how I should update evaluate-default-paths.yml. I can add that to the PR.

[elinor-fung]

Or maybe it could be narrowed down to
clrdefinitions.cmake
inc/
md/
minipal/
nativeresources/
pal/
palrt/
utilcode/

Based on a coarse search for CLR_DIR in mono.