System.Text.Json Source generator improvements for .NET 8.0

[layomia]

User story tracking source generator improvements for .NET 8.

System.Text.Json source generator improvements for .NET 8.0

Features

• System.Text.Json source generator fails to deserialize init-only & required properties #58770
• Json serializer code generator doesn't support internal constructors #77016
• Consider extending JsonIncludeAttribute and JsonConstructorAttribute support to internal and private members. #87431

Diagnostics

• JSON source generator emits CS0612 warnings if serialized types use [Obsolete] #76829
• Emit a diagnostic when encountering JsonConverterAttribute annotations with inaccessible converter type constructors. #87140
• System.Text.Json source generation producing invalid code on generic JsonSerializable types #61782

IDE Experience / generation speed

• System.Text.Json incremental source generator performance issues #68353

Runtime performance

• System.Text.Json fast path serialization not working with combined contexts #71933
• Order of serialized properties determined by dictionary enumeration on fast-path source generators #59043
• Source generator should share property-level custom converters #59041

AOT / size

• Developers should be able to use System.Text.Json in Native AOT seamlessly #79122

Reliability / bug fixes

Property visibility issues

• Developers should not encounter property visibility issues when using STJ source generation #79161

Contract configuration

• JSON source gen doesn't detect [JsonNumberHandling] when applied to POCO #58638

Other

• Can't use [JsonSerializable] with [Cloneable] source gen #65361
• System.Text.Json code generation fails on recursive IReadOnlyDictionary #76802
• System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx #63802

By-design / won't fix

• System.Text.Json Source Generator name conflicts #58938
• STJ Source Generator fails to do polymorphic serialization for built-in types #58134

Future

• Issue diagnostic warnings when custom JsonSerializerContext types don't indicate serializable types #58698
• JSON src-gen fast-path does not consider writer Encoder option #59424
• Share serialization tests between source-gen and reflection JsonSerializer #73714
• Consider adding Utf8JsonWriter support for writing raw property names #54005
• System.Text.Json using interpolated string with JsonSerializable.TypeInfoPropertyName fails with ArgumentException #69207
• Consider fast-path deserialization logic in JSON source generator #55043
• Support JsonExtensionData in source generator fast path #58943
• Consider unsealing JsonSourceGenerationOptionsAttribute #56206

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

User story tracking source generator improvements we deem to be impactful and should addressed fixed in .NET 8.

System.Text.Json Source generator improvements for .NET 8.0

Features

• Consider unsealing JsonSourceGenerationOptionsAttribute #56206
• Support JsonExtensionData in source generator fast path #58943
• Add JsonContent.Create overloads that accept JsonTypeInfo. #51544
• Json serializer code generator doesn't support internal constructors #77016

Diagnostics

• JSON source generator emits CS0612 warnings if serialized types use [Obsolete] #76829
• System.Text.Json Source Generator name conflicts #58938
• Issue diagnostic warnings when custom JsonSerializerContext types don't indicate serializable types #58698
• Consider sharing diagnostics issued by JSON source generator with reflection-based serializer #61262
• System.Text.Json code gen: collision when two classes share same name but different namespaces #58198

IDE Experience

• System.Text.Json incremental source generator performance issues #68353

Performance

• Micro-optimizations for STJ generated source #52218
• System.Text.Json fast path serialization not working with combined contexts #71933
• JSON src-gen fast-path does not consider writer Encoder option #59424
• Order of serialized properties determined by dictionary enumeration on fast-path source generators #59043
• Source generator should share property-level custom converters #59041

AOT

• [API Proposal]: A pattern for AOT-friendly source-generated JsonConverterFactory-based converters. #73124
• Get System.Text.Json.SourceGeneration tests running with NativeAot #73431
• Make KeyValuePair<,> support in JSON src-gen mode trim-safe #60072

Bug fixes

Property visibility issues

• Prevent source-gen from generating code for private fields and those marked with JsonIgnore #76919
• JsonSourceGenerationMode.Metadata emits references to internal members from another assembly #66679
• System.Text.Json source generator fails to deserialize init-only & required properties #58770
• System.Text.Json source generation should accept init-only properties with JsonIgnoreCondition.Always #66003

Other

• Can't use [JsonSerializable] with [Cloneable] source gen #65361
• System.Text.Json code generation fails on recursive IReadOnlyDictionary #76802
• System.Text.Json using interpolated string with JsonSerializable.TypeInfoPropertyName fails with ArgumentException #69207
• System.Text.Json using interpolated string with JsonSerializable.TypeInfoPropertyName fails with ArgumentException #69207
• System.Text.Json source generation producing invalid code on generic JsonSerializable types #61782
• STJ Source Generator fails to do polymorphic serialization for built-in types #58134
• System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx #63802
• Json source generator should support JsonConverter on non-nullable and nullable types #66547

Future

• Consider fast-path deserialization logic in JSON source generator #55043

Author:	layomia
Assignees:	-
Labels:	area-System.Text.Json, User Story
Milestone:	8.0.0

[eiriktsarpalis]

Closing as completed.