Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building clr shouldn't build host tests #73711

Open
eerhardt opened this issue Aug 10, 2022 · 4 comments
Open

Building clr shouldn't build host tests #73711

eerhardt opened this issue Aug 10, 2022 · 4 comments
Milestone

Comments

@eerhardt
Copy link
Member

Since #73095, we are now building the host subset when building clr. However, the host subset includes a few test directories:

<DefaultHostSubsets Condition="'$(DotNetBuildFromSource)' != 'true'">$(DefaultHostSubsets)+host.tests</DefaultHostSubsets>

and

add_subdirectory(test)

We should refactor our build so we don't need to build these tests when running a "normal" dev build: .\build.cmd libs+clr -rc Release.

@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Since #73095, we are now building the host subset when building clr. However, the host subset includes a few test directories:

<DefaultHostSubsets Condition="'$(DotNetBuildFromSource)' != 'true'">$(DefaultHostSubsets)+host.tests</DefaultHostSubsets>

and

add_subdirectory(test)

We should refactor our build so we don't need to build these tests when running a "normal" dev build: .\build.cmd libs+clr -rc Release.

Author: eerhardt
Assignees: -
Labels:

area-Host

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 10, 2022
@elinor-fung
Copy link
Member

Should we make clr include host.native instead of host? If it is just being included to use the live host, I don't think we need host packages or tools either.

@am11
Copy link
Member

am11 commented Aug 10, 2022

Yes, host.native sounds like the right subset for clr and mono defaults. Microsoft.NET.HostModel.dll is loaded when dotnet publish is used with --runtime argument (with or without -p:Publish{Aot,SingleFile,ReadyToRun}). We only use live host's dotnet publish in the installer tests.

Ideally, if we are building all (or enough) subsets, then crossgen2 build (and anything else which uses dotnet publish from global sdk during the build) can be deferred after the $RuntimeFlavor+host+libs, and then build.{cmd,sh} can handover control from runtime/.dotnet/dotnet to live host in order to increase reliance on live build of corehost and HostModel.

@elinor-fung
Copy link
Member

Switched to only include host.native in #73800.

The native tests assets are part of host.native though, so they will still be built.

@elinor-fung elinor-fung added this to the 8.0.0 milestone Aug 15, 2022
@elinor-fung elinor-fung removed the untriaged New issue has not been triaged by the area owner label Aug 15, 2022
@agocke agocke modified the milestones: 8.0.0, Future Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants