Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] ARM64 instructions cmle cmlt fcmle fcmlt are not emitted anywhere #64785

Open
TIHan opened this issue Feb 4, 2022 · 3 comments
Open

[JIT] ARM64 instructions cmle cmlt fcmle fcmlt are not emitted anywhere #64785

TIHan opened this issue Feb 4, 2022 · 3 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@TIHan
Copy link
Contributor

TIHan commented Feb 4, 2022

When doing this work: #64783, I noticed that the ARM64 instructions cmle cmlt fcmle fcmlt are not being emitted anywhere and we have no corresponding HW intrinsic APIs for them. We should find places where we can take advantage of these instructions.

category:cq
theme:emitter
skill-level:beginner
cost:small
impact:small

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Feb 4, 2022
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

When doing this work: #64783, I noticed that the ARM64 instructions cmle cmlt fcmle fcmlt are not being emitted anywhere and we have no corresponding HW intrinsic APIs to them.

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Feb 4, 2022

cc @tannergooding

@tannergooding
Copy link
Member

tannergooding commented Feb 4, 2022

👍. Just capturing what we were discussing offline...

This is one where we probably don't want a new managed intrinsic but rather where we can update lowering to do the containment and codegen to emit this for the existing AdvSimd.CompareLessThanOrEqual intrinsics when op2 is 0.
-- Basically what you did in #64783, but with the "is contained" and instruction change here: https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/hwintrinsiccodegenarm64.cpp#L525-L538

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 9, 2022
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 7.0.0, Future Feb 9, 2022
@JulieLeeMSFT JulieLeeMSFT added the help wanted [up-for-grabs] Good issue for external contributors label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

3 participants