Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure - Rollout (April 2021) #49889

Closed
ViktorHofer opened this issue Mar 19, 2021 · 8 comments
Closed

Infrastructure - Rollout (April 2021) #49889

ViktorHofer opened this issue Mar 19, 2021 · 8 comments
Assignees
Milestone

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 19, 2021

Overview

We use this issue to announce planned Infrastructure changes that will impact the developer workflow in dotnet/runtime. Changes will be merged on the first Monday of the month (4/5).

Change Impact Assignee
#50084 Update the minimum version of the SDK to 6.0 Preview 2. @ViktorHofer
#49715 Make Ninja the default CMake generator on Windows @jkoritzinsky
#49906 Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched @jkoritzinsky

Archive

@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Mar 19, 2021
@ghost
Copy link

ghost commented Mar 19, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

We use this issue to announce planned Infrastructure changes that will impact the developer workflow in dotnet/runtime. Changes will be merged on the first Monday of the month (5/4).

Change Impact Assignee
Update the minimum version of the SDK to 6.0 Preview 2. @ViktorHofer

Archive

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 19, 2021
@ViktorHofer ViktorHofer pinned this issue Mar 19, 2021
@trylek
Copy link
Member

trylek commented Mar 19, 2021

I originally added a mention of #49004 but I think it's probably not worth announcing as part of the rollout as its impact on developer flow is actually very minuscule.

@BruceForstall
Copy link
Member

@jkoritzinsky @trylek Did one of these changes make is so the native code PDBs are no longer copied to (for example) artifacts\bin\coreclr\windows.x64.Checked\PDB? There are managed code PDBs still there (e.g., crossgen2.pdb, R2RDump.pdb).

I notice there are still references to these things in RunTimeArtifactsExcludeFiles tags in src\tests\Common\Directory.Build.targets, that seem to indicate not having them there might prevent us from getting good core dumps in Helix runs.

@jkoritzinsky
Copy link
Member

Try pulling the main branch. There was a bug in one of the PRs in the rollout that has been fixed since.

@BruceForstall
Copy link
Member

Looks like #50819? Ok, I don't have that one.

@jkoritzinsky
Copy link
Member

Yep that's the fix.

@trylek
Copy link
Member

trylek commented Apr 7, 2021

Thanks so much Jeremy for figuring this out, I'm not sure if I'd have enough capacity for yet another bug investigation today :-).

@sadq30
Copy link

sadq30 commented May 5, 2021

Overview

We use this issue to announce planned Infrastructure changes that will impact the developer workflow in dotnet/runtime. Changes will be merged on the first Monday of the month (4/5).

Change Impact Assignee
#50084 Update the minimum version of the SDK to 6.0 Preview 2. @ViktorHofer
#49715 Make Ninja the default CMake generator on Windows @jkoritzinsky
#49906 Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched @jkoritzinsky

Archive

@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants