Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Remove completion feature flag and enable returning TextEdits by default #51439

Closed
allisonchou opened this issue Feb 24, 2021 · 2 comments
Closed

[LSP] Remove completion feature flag and enable returning TextEdits by default #51439

allisonchou opened this issue Feb 24, 2021 · 2 comments
Assignees
@allisonchou
Labels
Area-IDE Concept-Continuous Improvement LSP issues related to the roslyn language server protocol implementation
Milestone
17.3

Comments

@allisonchou
Copy link
Contributor

#51166 added a feature flag to LSP completion that enables returning TextEdits instead of InsertText. Once the team has tried this out and assessed its impact on performance, we should remove the feature flag and return TextEdits by default (provided it has acceptable performance).
@allisonchou allisonchou added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Feb 24, 2021
@allisonchou allisonchou self-assigned this Feb 24, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 24, 2021
@allisonchou allisonchou changed the title [LSP] Remove completion feature flag once data is collected [LSP] Remove completion feature flag and enable returning TextEdits by default Feb 24, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 24, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Feb 24, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, 17.0 Apr 27, 2021
@allisonchou
Copy link
Contributor Author

Moving to 17.0 to allow more time for feature flag testing and to do benchmark work.

@allisonchou allisonchou modified the milestones: 16.10, 17.0 Apr 27, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Sep 27, 2021
@allisonchou allisonchou modified the milestones: 17.1, 17.2 Jan 7, 2022
@allisonchou allisonchou modified the milestones: 17.2, 17.3 Mar 16, 2022
@dibarbet
Copy link
Member

Flag has been removed and we now return text edits by default in #60466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allisonchou allisonchou

Labels
Area-IDE Concept-Continuous Improvement LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.3
Development

No branches or pull requests
3 participants
@dibarbet @jinujoseph @allisonchou