Improve a couple of http kernel error messages #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamnamboodiripad
changed the title
colombod
reviewed
Feb 5, 2024
| @@ -1194,7 +1194,7 @@ public async Task invalid_option_produces_error() | |||
| """; | |||
|
|
|||
| var result = await kernel.SendAsync(new SubmitCode(code)); | |||
| result.Events.Should().ContainSingle<DiagnosticsProduced>().Which.Diagnostics.Should().ContainSingle().Which.Message.Should().Be("The supplied option 't' in the expression '$datetime 'yyyy-MM-dd' -1 t' is not supported."); | |||
| result.Events.Should().ContainSingle<DiagnosticsProduced>().Which.Diagnostics.Should().ContainSingle().Which.Message.Should().Be("The supplied option 't' in the expression '$datetime 'yyyy-MM-dd' -1 t' is not supported. The following options are supported: ms, s, m, h, d, w, M, Q, y. See https://aka.ms/http-date-time-format for more details."); | |||
There was a problem hiding this comment.
do we need this to be localised?
There was a problem hiding this comment.
Yes, all of the parser diagnostics need to be localized. And since the parser package is source-only, we need to do be able to localize in both the current repo and the internal repo. We have discussed this before and have some ideas around how to do this. There will be a follow up PR around this before long.
src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpDiagnostics.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Interactive.Http.Parsing/Parsing/HttpDiagnostics.cs
Show resolved
Hide resolved
jonsequitur
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including hyperlink that explains the expected format for the
$datetimeand$timestampdynamic variables in a couple more error messages.